Auto-loader: Must for a sharpshooter so you don't ever have to waste a turn not being able to shoot your rifle because you need to reload. Sharpshooters and rangers are already focused on OHKing their targets so equipping their stuff with a repeater would be a waste. Skirmishers are especially fun cause you get multiple chances per turn to execute stuff. Repeater: great on low-damage weapons, so specialists, reapers and skirmishers are the ideal candidates.
Scope: must have on sharpshooter, can be good on specialist, skirmisher, grenadier, reaper if you don't already have other upgrades taking up all the slots. Might have some value on a reaper for banish shenanigans, but you might as well take a repeater instead. Laser sight: must have for rangers cause they can get really high crit chances, others not so much. I would like to have your opinion to have the best optimal team setup for. XCOM2 What are the best weapon upgrades for each class? As the title says.